Join GitHub today
Prevent max call stack when merging overlapping keys #483
The merge implementation was intentionally minimal in scope, and an argument could be made for continuing to expect unique keys, but I ran into this issue with a fairly basic use-case – composing
To help evaluate this PR, I added an additional test which covers this use-case. It is a bit specific so I'm not sure it should land in master as is.
@@ Coverage Diff @@ ## master #483 +/- ## ===================================== Coverage 100% 100% ===================================== Files 1 1 Lines 173 173 ===================================== Hits 173 173