Skip to content

refactor: Port to TypeScript #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 31, 2020
Merged

refactor: Port to TypeScript #26

merged 13 commits into from
Mar 31, 2020

Conversation

@bebraw
Copy link
Collaborator

@bebraw bebraw commented Mar 17, 2020

Closes #24.

@bebraw bebraw requested a review from sapegin March 17, 2020 15:10
sapegin
sapegin reviewed Mar 17, 2020
View reviewed changes
bebraw
bebraw commented Mar 17, 2020
View reviewed changes
sapegin
sapegin reviewed Mar 17, 2020
View reviewed changes
@bebraw
Copy link
Collaborator Author

bebraw commented Mar 31, 2020

@sapegin This is good for another look. How can we make sure the next automated release is a major one? Maybe it's a nice idea to publish a beta before.

sapegin
sapegin reviewed Mar 31, 2020
View reviewed changes
@bebraw
Copy link
Collaborator Author

bebraw commented Mar 31, 2020

@sapegin Thanks for the review. I addressed your comments and dropped support for webpack 3 (easier typing now).

sapegin
sapegin approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@bebraw
Copy link
Collaborator Author

bebraw commented Mar 31, 2020

Looks good now!

Cool.

I noticed the CI was failing due to Prettier requiring Node 10 now so I pushed the project minimum to 10 as well. I think many developers are in 10/12 already.

@bebraw
Copy link
Collaborator Author

bebraw commented Mar 31, 2020

I wonder what happened with Travis integration. The build shows up at https://travis-ci.org/github/styleguidist/mini-html-webpack-plugin but I don't see anything on GitHub side anymore.

Let's merge anyhow?

@sapegin
Copy link
Member

sapegin commented Mar 31, 2020

I pushed the project minimum to 10 as well

Fine, Node 8 is no longer maintained.

@sapegin
Copy link
Member

sapegin commented Mar 31, 2020

Okay, I'll try to merge.

@sapegin sapegin merged commit 38c4656 into master Mar 31, 2020
@bebraw
Copy link
Collaborator Author

bebraw commented Mar 31, 2020

@sapegin Did we forget to do some semantic-release tweak? It doesn't seem to pick up the changes.

@sapegin
Copy link
Member

sapegin commented Mar 31, 2020

We can always check logs:

No changelog commit for this major release found and therefore a new version won’t be published:
To make a release, add a commit with a "Changelog:" tag and release notes in its body.

I'll get rid of that preset and use the default configuration.

@sapegin
Copy link
Member

sapegin commented Mar 31, 2020

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bebraw bebraw deleted the port-to-ts branch October 14, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapegin sapegin sapegin approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port to TypeScript

3 participants

@bebraw @sapegin