New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native example for Babel 7.x #1159

Closed
ProLoser opened this Issue Oct 5, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@ProLoser

ProLoser commented Oct 5, 2018

The example is for Babel 6.x and unfortunately half the install targets in the example will be for Babel 7.x and the other half for 6.x

It would be nice if we either updated the example to work with the latest babel version or documented what dependencies are needed for use with babel 6

For example there's now metro-react-native-babel-preset, @babel/core, @babel/preset-env and other variations from the previous babel version that make recreating this example a bit of a headache.

@sapegin

This comment has been minimized.

Show comment
Hide comment
@sapegin

sapegin Oct 5, 2018

Member

Feel free to send a pull request with updates!

Member

sapegin commented Oct 5, 2018

Feel free to send a pull request with updates!

@eragon512

This comment has been minimized.

Show comment
Hide comment
@eragon512

eragon512 Oct 13, 2018

Contributor

hey, is this issue available? if so, id like to take it up
could you also give a link to the examples in the docs, please?

Contributor

eragon512 commented Oct 13, 2018

hey, is this issue available? if so, id like to take it up
could you also give a link to the examples in the docs, please?

@sapegin

This comment has been minimized.

Show comment
Hide comment
@sapegin

sapegin Oct 13, 2018

Member

@eragon512 yup, feel free to it!

It’s in examples/react-native I believe.

Member

sapegin commented Oct 13, 2018

@eragon512 yup, feel free to it!

It’s in examples/react-native I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment