Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param of array #1623

Merged
merged 5 commits into from Jul 14, 2020
Merged

Fix param of array #1623

merged 5 commits into from Jul 14, 2020

Conversation

@isaacbuckman
Copy link
Contributor

@isaacbuckman isaacbuckman commented Jul 3, 2020

Doctrine has a function to stringify the parameter types. If the type is a string[], doctrine will stringify this into Array.<string>. I believe this is backwards compatible.

@isaacbuckman
Copy link
Contributor Author

@isaacbuckman isaacbuckman commented Jul 5, 2020

@sapegin Any idea on why the doctrine import does not seem to be working? It is working locally.

@sapegin
Copy link
Member

@sapegin sapegin commented Jul 7, 2020

It says 'Unknown type undefined' — likely we need to add some setup in the tests that are failing.

isaacbuckman added 3 commits Jul 7, 2020
@codecov
Copy link

@codecov codecov bot commented Jul 7, 2020

Codecov Report

Merging #1623 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
...lient/rsg-components/Argument/ArgumentRenderer.tsx 100.00% <100.00%> (ø)
src/client/rsg-components/Props/renderExtra.tsx 97.72% <0.00%> (+0.10%) ⬆️
@sapegin sapegin merged commit 921e8b1 into styleguidist:master Jul 14, 2020
10 checks passed
10 checks passed
Header rules - styleguidist No header rules processed
Details
Pages changed - styleguidist All files already uploaded
Details
Redirect rules - styleguidist No redirect rules processed
Details
Danger All green. Congrats.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - styleguidist No mixed content detected
Details
codecov/patch 100.00% of diff hit (target 97.13%)
Details
codecov/project 97.13% (+0.00%) compared to a45e213
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/styleguidist/deploy-preview Deploy preview ready!
Details
@sapegin
Copy link
Member

@sapegin sapegin commented Jul 14, 2020

Thanks, merging!

@styleguidist-bot
Copy link
Collaborator

@styleguidist-bot styleguidist-bot commented Sep 2, 2020

🎉 This PR is included in version 11.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.