WIP: Webpack 5 upgrade #1996
WIP: Webpack 5 upgrade #1996
Conversation
|
@sapegin What is your vision concerning the future of this project? I'm willing to help out with some maintenance ( like this pull request ). Do you have time to review / accept these updates? |
The validate function no longer returns an array with errors, but just throws errors for invalid configs
sure! I'll mainly work on updating dependencies. There is one issue however that I might need help with, as it seems that the algolia search is no longer working...#1992 |
|
I gave you write access to the repository ;-) |
The previous implementation resulted in the following error `TypeError: The 'compilation' argument must be an instance of Compilation` Instead of using a plain obj mock, use jest.mock to mock webpack.
Codecov Report
|
merge commits Arnout
Also removed Webpack 4 support.
fix: TypeScript errors in StyleguidistOptionsPlugin
This fixes build error / failing npm ci command: `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing
ThomasRoest
force-pushed
the
webpack-5-upgrade
branch
from
b28b56e
to
484c144
Compare
It was only used for a few webpack plugin types that have been replaced in #a949222
|
There are still a few unresolved comments, |
|
@sapegin should be good now right? |
|
There are still open comments and a lot of new |
|
sorry but I don't know which comments you are talking about, the ones from your review are resolved. |
|
I see at least one suggestion above, for the any and as — there should be none of them added to the codebase. This kind of code reviews take too much time from me, I'm tired of repeating everything 20 times, and I'm going to ignore any activity in this project in the future. Open source became too damaging to my mental health. |
I fixed those suggestions.
This is not realistic, there are always situations in which you need an escape hatch, and I can't replace all the existing any's and
I understand! But we've already put in alot of work for this pull request, so I would really like to complete this. Thank you! |
|
@sapegin i fixed the remaining new 'any's that I've missed in this pull request. Others where already in the code. |
Eslint no-shadow https://eslint.org/docs/latest/rules/no-shadow Disallow variable declarations from shadowing variables declared in the outer scope
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is a start for upgrading to webpack 5 and webpack-dev-server ^4. With these changes, the basic examples are working ( incl. hot module reloading ). But there are more todo's left
Todo
This fixes some issues like #1932
This requires a new major release