New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignoreFontFamilyName: [] option to font-family-no-duplicate-names #2086
Comments
Some further background on this I just noticed that this was included in • https://github.com/necolas/normalize.css/blob/master/README.md#pre-code-kbd-samp:
From the source cited above: https://en.wikipedia.org/wiki/User:Davidgothberg/Test59:
|
I think there is no harm in adding an option |
Originally I said:
But I guess you could specify So, I'm easy either way. If we use an option, can we make it one of those more generic ones that accept an array of user-defined options? e.g. `ignoreFontFamilyName: ["monospace"]. It addresses this use-case and, at little cost, adds some flexibility to the rule. |
^^ 👍 |
font-family-no-duplicate-names
Done in #2314 |
Follow up to #1284
There should be a way to ignore, or optionally ignore duplicate
monospace
font names infont-family-no-duplicate-names
Ways to approach this:
monospace, monospace
by defaultmonospace
duplicates, i.e.monospace, monospace
For context the above is based on the following comments in #1284:
Over in #1284 @ben-eb made the following comment:
I added a note below that:
I've still no idea if the above is a legitimate concern for modern browsers but though a rudimentary search of GitHub CSS for
monospace, monospace
returned 1 million plus results. A high probability that this issue would come up in the future based on those results. The article cites Google Chrome & Safari together, Chrome split from Webkit in Chrome 28 in mid 2013. As such mid 2013 browser versions would be my best guess at trying to guess the versions of browsers that this issue refers to, what has changed in regard to this issue for each browser since then I'm also unaware of /shrugThoughts @stylelint/core ?
The text was updated successfully, but these errors were encountered: