Allow non-existent codeFilenames #2128

Merged
merged 1 commit into from Nov 27, 2016

Projects

None yet

2 participants

@davidtheclark
Contributor

Closes #2064.

This was a little tricky to track down and fix without breaking other tests, but I think I got it.

The key is that we need to anticipate non-existent files in lintSource if code and codeFilename are being used.

@davidtheclark davidtheclark Allow non-existent codeFilenames
Closes #2064
3618001
@jeddy3
jeddy3 approved these changes Nov 27, 2016 View changes
@jeddy3
Member
jeddy3 commented Nov 27, 2016

Very nice! I can see how this one would've been tricky.

@davidtheclark davidtheclark merged commit 113cc67 into master Nov 27, 2016

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.07%) to 95.574%
Details
@davidtheclark davidtheclark deleted the 2064-stdin-filename branch Nov 27, 2016
@davidtheclark
Contributor

Changelog entry:

  • Fixed: regression causing --stdin-filename in CLI and codeFilename in Node API to error if a non-existent filename is provided (#2128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment