New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-existent codeFilenames #2128

Merged
merged 1 commit into from Nov 27, 2016

Conversation

2 participants
@davidtheclark
Contributor

davidtheclark commented Nov 26, 2016

Closes #2064.

This was a little tricky to track down and fix without breaking other tests, but I think I got it.

The key is that we need to anticipate non-existent files in lintSource if code and codeFilename are being used.

@jeddy3

jeddy3 approved these changes Nov 27, 2016

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 27, 2016

Very nice! I can see how this one would've been tricky.

@davidtheclark davidtheclark merged commit 113cc67 into master Nov 27, 2016

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.07%) to 95.574%
Details

@davidtheclark davidtheclark deleted the 2064-stdin-filename branch Nov 27, 2016

@davidtheclark

This comment has been minimized.

Contributor

davidtheclark commented Nov 27, 2016

Changelog entry:

  • Fixed: regression causing --stdin-filename in CLI and codeFilename in Node API to error if a non-existent filename is provided (#2128)

sergesemashko pushed a commit to sergesemashko/stylelint that referenced this pull request Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment