Use jest for rule tests #2158

Merged
merged 6 commits into from Dec 4, 2016

Projects

None yet

2 participants

@jeddy3
Member
jeddy3 commented Dec 3, 2016 edited

This PR ports the last of @davidtheclark's #2130 work to the no-babel code base.

It currently crashes with an out of memory error on my local machine, a 16gb Macbook Pro, even when not using the --runInBand flag.

This PR is here:

  1. For anyone to take a look at and investigate further why this crash occurs.
  2. To track any upstream performance changes in jest (at facebook/jest#2179)

Update: I can complete the run using npm run test:jest -- -w='4' in 52s on my local machine.

@jeddy3 jeddy3 changed the title from Use jest for rule tests to [WIP] Use jest for rule tests Dec 3, 2016
@jeddy3 jeddy3 referenced this pull request Dec 3, 2016
Closed

[WIP] Jest for rules #2130

@davidtheclark
Contributor

Looks like I got all the tests passing by removing graceful-fs from cosmiconfig!

Worth noting that the serialized Jest tests are significant slower than our tape script. But not too bad, I think.

Any objections to merging, then? (Good to know that it wouldn't be hard to revert, since we have the testRule abstraction.)

jeddy3 and others added some commits Dec 3, 2016
@jeddy3 @davidtheclark jeddy3 Use jest for rule tests 8999e75
@jeddy3 @davidtheclark jeddy3 Update regex to not exclude system-tests 025fcda
@davidtheclark davidtheclark Try experimental cosmiconfig fb0cf0c
@davidtheclark davidtheclark Try to make Travis pass 01104da
@davidtheclark davidtheclark Fix appveyor 02ab6fd
@davidtheclark davidtheclark Use released cosmiconfig
93518b7
@davidtheclark davidtheclark changed the title from [WIP] Use jest for rule tests to Use jest for rule tests Dec 4, 2016
@jeddy3
Member
jeddy3 commented Dec 4, 2016

Any objections to merging, then?

None, it's fantastic we're been able to migrate to jest wholesale!

Absolutely awesome job tracking down that memory leak!

@davidtheclark davidtheclark merged commit 16de92b into master Dec 4, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@davidtheclark davidtheclark deleted the jest-no-babel-rule-tests branch Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment