Lots of Flow work #2163

Merged
merged 1 commit into from Dec 4, 2016

Projects

None yet

3 participants

@davidtheclark
Contributor

Cleans up the aberrant spacing that Babel inflicted on Flow comments, and adds Flow comments to all of the utils.

@davidtheclark davidtheclark Lots of Flow work
d61dee3
*/
-module.exports = function (rule) {
+module.exports = function (rule/*: Object*/)/*: boolean*/ {
@m-allanson
m-allanson Dec 4, 2016 Member

Should this be postcss$rule instead of Object?

@davidtheclark
davidtheclark Dec 4, 2016 Contributor

@m-allanson The fact that we check for rule.params below means it's confusing — might not actually be a rule.

@m-allanson
Member

Nice. One question, otherwise LGTM.

@jeddy3
jeddy3 approved these changes Dec 4, 2016 View changes

Super nice

@jeddy3 jeddy3 merged commit fc3df1f into master Dec 4, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jeddy3 jeddy3 deleted the flow-flow-flow branch Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment