Ignore node_modules effectively #2171

Merged
merged 1 commit into from Dec 5, 2016

Projects

None yet

5 participants

@davidtheclark
Contributor

Closes #2149.

Managed to reproduce that problem in a test case, and made it pass. I'm not sure if this feature ever worked before in the PostCSS plugin; but we always intended it to, assumed it did, so I'd consider this a bug fix.

cc @simonsmith

lib/__tests__/ignore.test.js
@@ -365,3 +365,41 @@ describe("using codeFilename and ignoreFiles with configBasedir", () => {
expect(_.get(results[0], [ "_postcssResult", "standaloneIgnored" ])).toBeTruthy()
})
})
+
+describe("file in node_components", () => {
@davidtheclark
davidtheclark Dec 4, 2016 Contributor

:facepalm:

@simonsmith

Thanks for this @davidtheclark :)

@davidtheclark davidtheclark Ignore node_modules effectively
Closes #2149.
dce664f
@ntwb
ntwb approved these changes Dec 4, 2016 View changes

LGTM

@simonsmith simonsmith referenced this pull request in suitcss/preprocessor Dec 5, 2016
Closed

stylelint #58

@jeddy3
jeddy3 approved these changes Dec 5, 2016 View changes

so I'd consider this a bug fix.

Agreed.

@jeddy3 jeddy3 merged commit 08494be into master Dec 5, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jeddy3 jeddy3 deleted the 2149-ignore-node-modules branch Dec 5, 2016
@jeddy3
Member
jeddy3 commented Dec 5, 2016 edited

Changlelog:

  • Fixed: the node_modules and bower_components directories are correctly ignored by default when stylelint is used as a PostCSS plugin (#2171).
@simonsmith simonsmith referenced this pull request Dec 9, 2016
Closed

Release 7.7.0 #2161

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment