New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore node_modules effectively #2171

Merged
merged 1 commit into from Dec 5, 2016

Conversation

5 participants
@davidtheclark
Contributor

davidtheclark commented Dec 4, 2016

Closes #2149.

Managed to reproduce that problem in a test case, and made it pass. I'm not sure if this feature ever worked before in the PostCSS plugin; but we always intended it to, assumed it did, so I'd consider this a bug fix.

cc @simonsmith

@@ -365,3 +365,41 @@ describe("using codeFilename and ignoreFiles with configBasedir", () => {
expect(_.get(results[0], [ "_postcssResult", "standaloneIgnored" ])).toBeTruthy()
})
})
describe("file in node_components", () => {

This comment has been minimized.

@simonsmith

simonsmith Dec 4, 2016

Contributor

node_modules?

This comment has been minimized.

@davidtheclark

davidtheclark Dec 4, 2016

Contributor

:facepalm:

@simonsmith

This comment has been minimized.

Contributor

simonsmith commented Dec 4, 2016

Thanks for this @davidtheclark :)

@davidtheclark davidtheclark force-pushed the 2149-ignore-node-modules branch from 49bc5e5 to dce664f Dec 4, 2016

@ntwb

ntwb approved these changes Dec 4, 2016

LGTM

@davidtheclark davidtheclark force-pushed the 2149-ignore-node-modules branch from 5ce4660 to dce664f Dec 4, 2016

@simonsmith simonsmith referenced this pull request Dec 5, 2016

Closed

stylelint #58

@jeddy3

jeddy3 approved these changes Dec 5, 2016

so I'd consider this a bug fix.

Agreed.

@jeddy3 jeddy3 merged commit 08494be into master Dec 5, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jeddy3 jeddy3 deleted the 2149-ignore-node-modules branch Dec 5, 2016

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Dec 5, 2016

Changlelog:

  • Fixed: the node_modules and bower_components directories are correctly ignored by default when stylelint is used as a PostCSS plugin (#2171).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment