Simplify NPM test scripts now that Tape has been removed #2172

Merged
merged 2 commits into from Dec 6, 2016

Projects

None yet

3 participants

@ntwb
Member
ntwb commented Dec 4, 2016

Now that Tape was removed in #2158 there's no need for multiple tape:* scripts.

@ntwb ntwb Simplify NPM test scripts now that Tape has been removed
9ead2ff
package.json
- "test": "npm-run-all --serial test:*",
- "watch": "npm run test:jest -- --watch"
+ "test": "jest",
+ "watch": "npm run jest -- --watch"
@jeddy3
jeddy3 Dec 5, 2016 Member

Can we have just jest --watch here please? I sometimes find the extra -- unreliable when passing further flags into the npm command e.g. npm run watch -- logHeapSize.

@ntwb
ntwb Dec 6, 2016 Member

Running npm run watch works as expected using "watch": "npm run jest -- --watch"

Running npm run watch does not work using "watch": "npm run jest --watch", this results in the Jest tests being ran and the watch mode is never started:

> stylelint@7.6.0 watch /Users/netweb/dev/stylelint/stylelint
> npm run jest --watch


> stylelint@7.6.0 jest /Users/netweb/dev/stylelint/stylelint
> jest

 PASS  lib/rules/value-keyword-case/__tests__/index.js
...
...
@davidtheclark
davidtheclark Dec 6, 2016 Contributor

@ntwb I think the request is for "watch": "jest --watch".

@ntwb
ntwb Dec 6, 2016 Member

Done in ff6acfe :)

@jeddy3
Member
jeddy3 commented Dec 5, 2016 edited

Neater, thanks :) I've made a request, though.

@ntwb
Member
ntwb commented Dec 6, 2016

Followed up inline, tl;dr: requested change doesn't work

@ntwb ntwb Simplify watch script command
ff6acfe
@ntwb
Member
ntwb commented Dec 6, 2016

All sorted now 👍

@jeddy3
jeddy3 approved these changes Dec 6, 2016 View changes
@jeddy3
Member
jeddy3 commented Dec 6, 2016

Thanks :)

@jeddy3 jeddy3 merged commit 8c3e0d6 into master Dec 6, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jeddy3 jeddy3 deleted the npm-scripts branch Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment