New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add except: ["after-same-name"] option to at-rule-empty-line-before #2225

Merged
merged 1 commit into from Jan 8, 2017

Conversation

2 participants
@hudochenkov
Member

hudochenkov commented Dec 31, 2016

Which issue, if any, is this issue related to?

#2211

Is there anything in the PR that needs further explanation?

Maybe "after-same-name" should be placed before "blockless-after-same-name-blockless" in docs, because of its broader nature?

Should I add ignore: ["after-same-name"] also?

@hudochenkov hudochenkov force-pushed the hudochenkov:after-same-name branch 2 times, most recently from 34f9507 to 5d7f744 Dec 31, 2016

@jeddy3

@hudochenkov Thanks!

Besides one very minor request, looks great to me!

@@ -31,6 +31,7 @@ const rule = function (expectation, options) {
"blockless-after-same-name-blockless",
"blockless-group",
"first-nested",
"after-same-name",

This comment has been minimized.

@jeddy3

jeddy3 Dec 31, 2016

Member

These options should be in alphabetical order

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Dec 31, 2016

Maybe "after-same-name" should be placed before "blockless-after-same-name-blockless" in docs, because of its broader nature?

Options should be order alphabetically within the docs, as it's simpler to maintain that consistency across READMEs than any other system.

Should I add ignore: ["after-same-name"] also?

Nope, we only add options once there has been a real-world request for it rather than preemptively adding them.

@hudochenkov hudochenkov force-pushed the hudochenkov:after-same-name branch from 5d7f744 to c69bbd4 Dec 31, 2016

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Dec 31, 2016

Done.

@jeddy3

jeddy3 approved these changes Dec 31, 2016

@@ -100,6 +101,8 @@ const rule = function (expectation, options) {
// Optionally reverse the expectation if any exceptions apply
if (
|| optionsMatches(options, "except", "after-same-name")

This comment has been minimized.

@jeddy3

jeddy3 Dec 31, 2016

Member

I think your syntax is wrong here.

This comment has been minimized.

@hudochenkov

hudochenkov Dec 31, 2016

Member

Sorry about that. It's fixed now.

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jan 1, 2017

Sorry about that. It's fixed now.

@hudochenkov Thanks! I'm going to wait on the outcome of #2231 before merging. Feel free to add your thoughts to that discussion. We've a much better grasp of what options are needed than we had a few months ago and 8.0.0 is our opportunity to standardise all the options based on our learnings.

@jeddy3

jeddy3 approved these changes Jan 8, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jan 8, 2017

Merging as per #2231 (comment)

@jeddy3 jeddy3 merged commit 8888dd7 into stylelint:master Jan 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jan 8, 2017

@hudochenkov Thanks!

Changelog

  • Added: except: ["after-same-name"] option to at-rule-empty-line-before (#2225).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment