Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix handling of shared-line comments #2262
Introduces a number of utilities and adjusts the following rules:
This turned out to be a lot of work
I bet! It's looking great though.
However, (and I don't think you're going to like this as it might mean there's a little more legwork to do), there could be a couple of conflicts down the line if we merge this now. In #2213 we standardised a couple of options. This PR was merged into the
I think only a small fraction of the PR is going to conflict; perhaps just the doc changes and
What do you think is the best way to go about merging? Originally, I thought
Can we merge this PR into
Fantastic job! You did much better than I think would do :)
I especially like how you did
getPreviousNonSharedLineCommentNode. I didn't think of shared-line comment before node. You have much broader view on possible code styles.
Also this PR closes #2212.
@davidtheclark please, take a look at
Update: I was looking at the first commit in this PR, and now I see you make some changes in
As I know