New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate additional rules #2285

Merged
merged 2 commits into from Jan 28, 2017

Conversation

5 participants
@m-allanson
Member

m-allanson commented Jan 24, 2017

Which issue, if any, is this issue related to?

#2123

Is there anything in the PR that needs further explanation?

Deprecates the following rules:

  • no-browser-hacks
  • no-indistinguishable-colors
  • no-unsupported-browser-features
  • stylelint-disable-reason
  • custom-property-no-outside-root
  • root-no-standard-properties
  • selector-root-no-composition
  • time-no-imperceptible
@hudochenkov

Well done!

@@ -1,5 +1,7 @@
# time-no-imperceptible
***Deprecated: this rule is outside the scope of stylelint's functionality. See [the release planning docs](https://stylelint.io/user-guide/release-planning/) for details.***

This comment has been minimized.

@ntwb

ntwb Jan 24, 2017

Member

This time-no-imperceptible rule is being replaced with a more appropriately and more versatile rule named time-min-milliseconds. See #2249

This comment has been minimized.

@hudochenkov

hudochenkov Jan 25, 2017

Member

But technically new rule isn't here yet. What if it wouldn't be here when these changes will be released?

This comment has been minimized.

@jeddy3

jeddy3 Jan 25, 2017

Member

We won't be releasing the deprecations branch until the alternative within stylelint are done. So, updating this message to reference time-min-milliseconds SGTM. Otherwise we'll likely forget to do it when time-min-milliseconds is added.

This comment has been minimized.

@hudochenkov

hudochenkov Jan 26, 2017

Member

Agreed. time-min-milliseconds is on its way #2289

This comment has been minimized.

@jeddy3

jeddy3 Jan 26, 2017

Member

Awesome. Let's update this message to:

***Deprecated: use the time-min-milliseconds rule with 100 as its primary option. ***

@ntwb

Should we reference the new rule in the deprecation message?

@m-allanson

This comment has been minimized.

Member

m-allanson commented Jan 24, 2017

@ntwb I think that's a good idea. Just looking at the latest changelog, maybe I should add ' If you use this rule, please consider creating a plugin for the community.' to some of the other rules.

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jan 26, 2017

Epic job with this @m-allanson btw! 8.0.0 moves ever closer :)

@davidtheclark davidtheclark merged commit feb4a90 into deprecations Jan 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@davidtheclark davidtheclark deleted the deprecate-additional-rules branch Jan 28, 2017

This was referenced Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment