New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max-line-length column incorrect column #2287

Merged
merged 2 commits into from Jan 29, 2017

Conversation

3 participants
@m-allanson
Member

m-allanson commented Jan 24, 2017

Which issue, if any, is this issue related to?

#2286

Is there anything in the PR that needs further explanation?

The test will fail with:

FAIL  lib/rules/max-line-length/__tests__/index.js
  ● max-line-length › reject › no description

    expect(received).toBe(expected)

    Expected value to be (using ===):
      48
    Received:
      30

      at stylelint.then.output (jest-setup.js:55:50)

@jeddy3 jeddy3 changed the title from Failling test for max-line-length column issue to Fix max-line-length column incorrect column Jan 26, 2017

@davidtheclark davidtheclark force-pushed the max-line-length-bad-column branch from 5942c48 to 646f50c Jan 28, 2017

@davidtheclark

This comment has been minimized.

Contributor

davidtheclark commented Jan 28, 2017

I added a commit that fixes this test, so closes #2286.

It also fixes the incorrect positions in system test 005 that corresponded to this problem.

@jeddy3

jeddy3 approved these changes Jan 29, 2017

@davidtheclark Excellent, thanks for that! LGTM.

@davidtheclark davidtheclark merged commit 1d6f21f into master Jan 29, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@davidtheclark davidtheclark deleted the max-line-length-bad-column branch Jan 29, 2017

@davidtheclark

This comment has been minimized.

Contributor

davidtheclark commented Jan 29, 2017

Added to Changelog:

  • Fixed: max-line-length no longer reports incorrect column positions for lines with url() or import (#2287).

sergesemashko pushed a commit to sergesemashko/stylelint that referenced this pull request Mar 3, 2017

Fix max-line-length column incorrect column (stylelint#2287)
* Add a failing test for issue stylelint#2286

* Fix max-line-length column number for lines with urls

Closes stylelint#2286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment