New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore: ["comments"] option to max-empty-lines #2401

Merged
merged 2 commits into from Mar 15, 2017

Conversation

5 participants
@sendilkumarn
Contributor

sendilkumarn commented Feb 27, 2017

Add ignore: ["comments"] option to max-empty-lines

Which issue, if any, is this issue related to?

fixes #2356

Is there anything in the PR that needs further explanation?

Adds ignore comments option to max-empty-lines

accept: [ {
code: "a{}\r\n\r\n/*\n\n\n\nhorse */\r\n\r\nb{}",
}, {
code: "a{}\r\n\r\n/** \r\n\r\n\r\n\nhor\r\n\r\n\r\nse */\r\n\r\nb{}",

This comment has been minimized.

@evilebottnawi

evilebottnawi Feb 27, 2017

Member

Be good added test between properties and value (display: /* some long comments */ block;, display: block /* some long comments */;, display/* some long comments */: block;).

This comment has been minimized.

@sendilkumarn

sendilkumarn Feb 27, 2017

Contributor

Thanks @evilebottnawi added 👍

Add ignore: ["comments"] option to max-empty-lines
Add ignore: ["comments"] option to max-empty-lines

added more test cases

@sendilkumarn sendilkumarn force-pushed the sendilkumarn:ignore-comment-max-empty-line branch from 585f50d to 2f4692e Feb 27, 2017

*
* Some years ago -- never mind how log precisely -- ...
*/
```

This comment has been minimized.

@hudochenkov

hudochenkov Mar 1, 2017

Member

This example is almost exactly as the next example. Can you delete one or change it for something different, please? E. g. put this comment into a {}.

@sendilkumarn

This comment has been minimized.

Contributor

sendilkumarn commented Mar 14, 2017

Is this pending for any other reason ?

@davidtheclark

This comment has been minimized.

Contributor

davidtheclark commented Mar 15, 2017

Thanks @sendilkumarn: looks great!

@davidtheclark davidtheclark merged commit 09c75f0 into stylelint:master Mar 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davidtheclark

This comment has been minimized.

Contributor

davidtheclark commented Mar 15, 2017

Added to Changelog:

  • Added: ignore: ["comments"] to max-empty-lines (#2401).

evilebottnawi added a commit that referenced this pull request Mar 21, 2017

Add ignore: ["comments"] option to max-empty-lines (#2401)
* Add ignore: ["comments"] option to max-empty-lines

Add ignore: ["comments"] option to max-empty-lines

added more test cases

* changed examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment