New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added supports for sass syntax #2503

Merged
merged 2 commits into from Jan 20, 2018

Conversation

6 participants
@AleshaOleg
Contributor

AleshaOleg commented Apr 15, 2017

No description provided.

@davidtheclark

This comment has been minimized.

Contributor

davidtheclark commented Apr 22, 2017

As far as I know, this is waiting on resolution to the discussion in #2486 about whether the parser is ready for stylelint-prime-time or not — right?

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Apr 24, 2017

about whether the parser is ready for stylelint-prime-time or not — right?

Yep, I think we'll need to, in #2486:

  1. Assess the parsers compatibility with the core rules. So we can determine much work is required to add any missing compatibility.
  2. Try to gauge whether the parser will have maintainer support in long term. So we can determine how to balance the overall health of the project with making the tool useful to a new user base.
@evilebottnawi

Seems good, but need integration tests

@ntwb

This comment has been minimized.

Member

ntwb commented Nov 27, 2017

It looks like this now has some tests been added, updating to needs review again

@gucong3000

This comment has been minimized.

Member

gucong3000 commented Nov 28, 2017

@AleshaOleg

This comment has been minimized.

Contributor

AleshaOleg commented Nov 28, 2017

@gucong3000 but i can't say where is parse error. Or i'm wrong? Because in postcss-sass i'm just using gonzales-pe to parse Sass and then simply transform their AST to PostCSS AST format.

Also, I will glad if somebody will help me to test map, list (like this kind of syntax: https://github.com/AleshaOleg/postcss-sass/blob/development/__tests__/sass/map2comment.sass) which i recently added. I plan to release 0.3.0 asap. But I still need more tests to do this.

@AleshaOleg

This comment has been minimized.

Contributor

AleshaOleg commented Dec 23, 2017

@gucong3000 sorry for too long response:)
I finally merged your changes to postcss-sass! Now I think it's ready to be released as 0.3.0 version. Is any things do I need to support in postcss-sass to make it works with stylelint?

@AleshaOleg

This comment has been minimized.

Contributor

AleshaOleg commented Dec 23, 2017

Happy holidays 🎉 🎅 🍾

@AleshaOleg

This comment has been minimized.

Contributor

AleshaOleg commented Dec 23, 2017

@gucong3000 invited you as collaborators to postcss-sass. Feel free to make any changes! Again, thanks, for pr's

@gucong3000

This comment has been minimized.

Member

gucong3000 commented Dec 25, 2017

@AleshaOleg
Thank you for your trust.

@AleshaOleg

This comment has been minimized.

Contributor

AleshaOleg commented Jan 19, 2018

@gucong3000 fixed for now.

@AleshaOleg

This comment has been minimized.

Contributor

AleshaOleg commented Jan 19, 2018

Released postcss-sass@0.3.0.

@AleshaOleg

This comment has been minimized.

Contributor

AleshaOleg commented Jan 19, 2018

@gucong3000 do we need everything to make a stylelint support sass files?

@gucong3000

This comment has been minimized.

Member

gucong3000 commented Jan 19, 2018

I think this PR is ready for merge now.

@ntwb

ntwb approved these changes Jan 20, 2018

LGTM 👍

@ntwb ntwb merged commit 207c662 into stylelint:master Jan 20, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 95.537%
Details
@ntwb

This comment has been minimized.

Member

ntwb commented Jan 20, 2018

Changelog : 793dd73

  • Added: (experimental) support for SASS syntax (#2503).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment