New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: ignore custom property sets in selector rules. #2634

Merged
merged 1 commit into from Jun 15, 2017

Conversation

3 participants
@evilebottnawi
Member

evilebottnawi commented Jun 13, 2017

Which issue, if any, is this issue related to?

#2631

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

/cc @jeddy3

Some note:

  1. Add
 {
    code: ":root { --foo: 1px; }",
    description: "custom property in root",
  }, {
    code: "html { --foo: 1px; }",
    description: "custom property in selector",
  }, {
    code: ":root { --custom-property-set: {} }",
    description: "custom property set in root",
  }, {
    code: "html { --custom-property-set: {} }",
    description: "custom property set in selector",
  }

to all selector-* rules, it seems some superfluous, but after spec will become Recommendation, we can move all this tests to basic.
2. All { } to {} in tests (extra unnecessary space in { }).

@jeddy3

I guess there's no harm in being thorough in the tests :)

@@ -1,6 +1,7 @@
"use strict"
const _ = require("lodash")
const isCustomPropertySet = require("../../utils/isCustomPropertySet")

This comment has been minimized.

@jeddy3

jeddy3 Jun 13, 2017

Member

Pls remove

if (!isStandardSyntaxRule(node)) {
return
}
selector = node.selector
} else if (node.type === "atrule" && node.name === "page" && node.params) {

This comment has been minimized.

@jeddy3

jeddy3 Jun 13, 2017

Member

Use isStandardSyntaxAtRule here for completeness -

if (!isStandardSyntaxAtRule(node)) {
return
}

@evilebottnawi evilebottnawi force-pushed the issue-2631-tests branch from f5fa7de to 626b3bd Jun 13, 2017

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Jun 13, 2017

@jeddy3 done

@jeddy3

jeddy3 approved these changes Jun 13, 2017

LGTM

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 13, 2017

I'll do a patch release once this and #2632 are in.

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Jun 13, 2017

@jeddy3 yep 👍

@jeddy3 jeddy3 merged commit 9baf0d0 into master Jun 15, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 95.63%
Details

@jeddy3 jeddy3 deleted the issue-2631-tests branch Jun 15, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 15, 2017

  • Fixed: selector-* now ignore custom property sets (#2634).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment