New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: `selector-max-universal` rule. #2653

Merged
merged 1 commit into from Jun 26, 2017

Conversation

3 participants
@evilebottnawi
Member

evilebottnawi commented Jun 20, 2017

Which issue, if any, is this issue related to?

#2528

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@evilebottnawi evilebottnawi requested review from hudochenkov and jeddy3 Jun 20, 2017

@evilebottnawi evilebottnawi force-pushed the selector-max-universal branch from c7616f4 to d4c5d58 Jun 20, 2017

@hudochenkov

Good job!

Please, remove package.json from PR.

column: 1,
}, {
code: "*, \n* * * {}",
description: "multiple selectors: greater than max classes",

This comment has been minimized.

@hudochenkov

hudochenkov Jun 20, 2017

Member

"multiple selectors: greater than max universal selectors"

@jeddy3

jeddy3 requested changes Jun 20, 2017 edited

@evilebottnawi Thanks!

```css
/* each selector in a selector list is evaluated separately */
*.foo *,

This comment has been minimized.

@jeddy3

jeddy3 Jun 20, 2017

Member

Please change to:

*.foo,
*.bar * {}

That that only three (one more than the max) universal selectors are used.

```
```css
/* `*` is inside `:not()`, so it is evaluated separately */

This comment has been minimized.

@jeddy3

jeddy3 Jun 20, 2017

Member

Please change to:

* > * .foo:not(*) {}
@jeddy3

jeddy3 approved these changes Jun 26, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 26, 2017

@hudochenkov I've made the changes if you'd like to look them over?

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Jun 26, 2017

@jeddy3 looks good. Thanks!

@jeddy3 jeddy3 force-pushed the selector-max-universal branch from f7ccdda to ebecce3 Jun 26, 2017

@jeddy3 jeddy3 force-pushed the selector-max-universal branch from ebecce3 to 8aa12c0 Jun 26, 2017

@jeddy3 jeddy3 merged commit ab61481 into master Jun 26, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 95.647%
Details

@jeddy3 jeddy3 deleted the selector-max-universal branch Jun 26, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 26, 2017

  • Added: selector-max-universal rule (#2653).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment