New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: `selector-max-id` rule. #2654

Merged
merged 4 commits into from Jun 26, 2017

Conversation

3 participants
@evilebottnawi
Member

evilebottnawi commented Jun 20, 2017

Which issue, if any, is this issue related to?

#2528

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@hudochenkov

Good job!

column: 1,
}, {
code: "#foo, \n#bar #baz #foo {}",
description: "multiple selectors: greater than max classes",

This comment has been minimized.

@hudochenkov

hudochenkov Jun 20, 2017

Member

"multiple selectors: greater than max id selectors"

@jeddy3 jeddy3 force-pushed the selector-max-id branch from 60611eb to 1ed0241 Jun 26, 2017

@jeddy3

jeddy3 approved these changes Jun 26, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 26, 2017

@hudochenkov I've made the changes. Do they look good to you?

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Jun 26, 2017

@jeddy3 looks good!

@jeddy3 jeddy3 merged commit 34df36f into master Jun 26, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 95.653%
Details

@jeddy3 jeddy3 deleted the selector-max-id branch Jun 26, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 26, 2017

Changelog:

  • Added: selector-max-id rule (#2654).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment