New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate replaced rules #2679

Merged
merged 1 commit into from Jun 26, 2017

Conversation

2 participants
@jeddy3
Member

jeddy3 commented Jun 26, 2017

Closes #2528
Closes #2513

Tests should pass once the remaining two max- rules are merged into master and this is rebased.

@jeddy3 jeddy3 referenced this pull request Jun 26, 2017

Closed

Release 7.12 #2574

5 of 5 tasks complete
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 26, 2017

@hudochenkov This is rebased now and ready for review.

@jeddy3 jeddy3 force-pushed the deprecate-no-data-rules branch from 2047476 to 4d1279d Jun 26, 2017

@hudochenkov

Good job!

@jeddy3 jeddy3 merged commit a72ffdd into master Jun 26, 2017

2 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeddy3 jeddy3 deleted the deprecate-no-data-rules branch Jun 26, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 26, 2017

Changlog:

  • Deprecated: 6 rules, each has been replaced by a more configurable alternative (#2679).
    - function-url-data-uris rule. Use either function-url-scheme-blacklist or function-url-scheme-whitelist.
    - selector-no-attribute rule. Use selector-max-attribute with 0 as its primary option.
    - selector-no-combinator rule. Use selector-max-combinators with 0 as its primary option.
    - selector-no-id rule. Use selector-max-id with 0 as its primary option.
    - selector-no-type rule. Use selector-max-type with 0 as its primary option.
    - selector-no-universal rule. Use selector-max-universal with 0 as its primary option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment