New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore nested non-standard selectors in selector-max-specificity #2685

Merged
merged 2 commits into from Jun 30, 2017

Conversation

3 participants
@jeddy3
Member

jeddy3 commented Jun 27, 2017

Closes #2684

@hudochenkov

Can we also close #2677 with this PR?

@@ -12,6 +12,8 @@ Visit the [Specificity Calculator](https://specificity.keegan.st) for visual rep
This rule ignores selectors with variable interpolation (`#{$var}`, `@{var}`, `$(var)`).
This rule ignores all selectors, standard syntax or otherwise, nested within non-standard rule constructs e.g. `@each`.

This comment has been minimized.

@hudochenkov

hudochenkov Jun 27, 2017

Member

I can't understand this sentence :(

This comment has been minimized.

@jeddy3

jeddy3 Jun 27, 2017

Member

I pulled this out as I think the preceding statement is good enough:

This rule ignores selectors with variable interpolation (#{$var}, @{var}, $(var)).

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 27, 2017

Can we also close #2677 with this PR?

I'm afraid not as we don't have a heuristic in isStandardSyntaxSelector yet to determine that .myMixin(@a, @b).bar is non-standard.

@jeddy3 jeddy3 merged commit 863ed85 into master Jun 30, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 95.677%
Details

@jeddy3 jeddy3 deleted the issue-2684 branch Jun 30, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 30, 2017

  • Fixed: selector-max-specificity now ignores nested non-standard selectors (#2685).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment