New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS namespace false positives in selector-combinator-space-* #2715

Merged
merged 2 commits into from Jul 7, 2017

Conversation

3 participants
@jeddy3
Member

jeddy3 commented Jul 3, 2017

Closes #2711

Use the original selector string, rather than stringify the selector tree. Stringifying the tree also seemed wasteful.

@ntwb

ntwb approved these changes Jul 4, 2017

LGTM

@jeddy3 jeddy3 merged commit 57e71a3 into master Jul 7, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.677%
Details

@jeddy3 jeddy3 deleted the issue-2711 branch Jul 7, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jul 7, 2017

  • Fixed: selector-combinator-space-* false positives for CSS namespaced type selectors (#2715).

@jeddy3 jeddy3 changed the title from Issue 2711 to Fix CSS namespace false positives in selector-combinator-space-* Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment