New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignoreAttributes for selector-max-attribute #2722

Merged
merged 3 commits into from Jul 10, 2017

Conversation

3 participants
@joscha
Contributor

joscha commented Jul 7, 2017

This adds an ignoreAttributes option to the selector-max-attribute rule, similar to the ignoreTypes option of the selector-max-type rule.

References #1706

joscha added some commits Jul 7, 2017

@jeddy3

@joscha Thanks!

LGTM besides one documentation request.

["/^my-/", "dir"]
```
For example, with `2`.

This comment has been minimized.

@jeddy3

jeddy3 Jul 7, 2017

Member

"For example, with 0."

With 2 it wouldn't be considered a violation as there are only two attributes selectors in the example.

This comment has been minimized.

@joscha

joscha Jul 9, 2017

Contributor

Ah, ta, will update.

@joscha

This comment has been minimized.

Contributor

joscha commented Jul 9, 2017

@jeddy3 documentation updated!

@jeddy3

jeddy3 approved these changes Jul 10, 2017

LGTM

@joscha

This comment has been minimized.

Contributor

joscha commented Jul 10, 2017

awesome @jeddy3 - can you let me know when this is appearing in a new version, please?

@jeddy3 jeddy3 merged commit 945a188 into stylelint:master Jul 10, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 95.68%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jul 10, 2017

  • Added: ignoreAttributes option to selector-max-attribute (#2722).
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jul 10, 2017

@joscha It's in 7.13.0. Thanks again for your contribution.

@joscha

This comment has been minimized.

Contributor

joscha commented Jul 10, 2017

@joscha joscha deleted the joscha:joscha/selector-max-attribute/ignoreAttributes branch Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment