New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ignorePattern option. #2834

Merged
merged 1 commit into from Sep 1, 2017

Conversation

5 participants
@satazor
Contributor

satazor commented Aug 24, 2017

Closes #2832

@@ -117,22 +118,27 @@ module.exports = function(
// Check for file existence
return new Promise((resolve, reject) => {
if (!absoluteCodeFilename) {
reject()

This comment has been minimized.

@satazor

satazor Aug 24, 2017

Contributor

These changes are unrelated. I guess prettier/eslint made those.

@evilebottnawi

Oh, wow! Good work! Thanks! Seems something wrong with prettier or our configuration, but it is not related to this PR.

@satazor

This comment has been minimized.

Contributor

satazor commented Aug 24, 2017

@evilebottnawi Thanks! Hoping we can get this landed quickly :D

@satazor

This comment has been minimized.

Contributor

satazor commented Aug 28, 2017

This PR is quite simple and I really need this feature. Otherwise I will have to do a wrapper to create a temporary file with the contents of --ignore-pattern and pass it through --ignore-file.

Could you guys review this quicker? Thanks

@ntwb

This comment has been minimized.

Member

ntwb commented Aug 30, 2017

@satazor Apologies, I'm trying to sort out what and why Prettier is making the extra changes in this PR

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Aug 30, 2017

@ntwb maybe because our code initially was formatted with Prettier older than 1.5.3, which @satazor might use. Even minor version might change formatting. I think we should use ~ in package.json for Prettier as we do with linters.

@satazor satazor force-pushed the satazor:ignore-pattern branch from 19c1e6a to 364fadc Aug 30, 2017

@satazor satazor force-pushed the satazor:ignore-pattern branch from 364fadc to 615bdf3 Aug 30, 2017

@satazor

This comment has been minimized.

Contributor

satazor commented Aug 30, 2017

I've committed with -n to bypass prettier so that it doesn't get into the way.

This way we can get this merged and sort out the prettier issue later.

@satazor

This comment has been minimized.

Contributor

satazor commented Aug 30, 2017

Bump.

@jeddy3

jeddy3 approved these changes Aug 31, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Aug 31, 2017

@satazor Thanks for this. LGTM.

Let's try to get this into 8.1.0

Could you guys review this quicker? Thanks

A couple of the core team have been away (holidays, relocating etc) for the last few weeks. And so, we're currently working through a backlog of issues.

@jeddy3 jeddy3 referenced this pull request Aug 31, 2017

Closed

Release 8.1.0 #2838

6 of 6 tasks complete

@ntwb ntwb merged commit 32422ab into stylelint:master Sep 1, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0006%) to 95.64%
Details
@ntwb

This comment has been minimized.

Member

ntwb commented Sep 1, 2017

Changelog updated via 14163e0

  • Added: ignorePattern option (--ignore-pattern in CLI), to allow patterns of files to ignored (#2834).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment