New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix --ignorePattern not working for the CLI. #2851

Merged
merged 1 commit into from Sep 5, 2017

Conversation

5 participants
@satazor
Contributor

satazor commented Sep 4, 2017

#2834 was incomplete.

I totally missed the CLI assignment.

@satazor

This comment has been minimized.

Contributor

satazor commented Sep 4, 2017

//cc @ntwb @jeddy3

@evilebottnawi

Oh, thanks!

@andreffvalente

This comment has been minimized.

andreffvalente commented Sep 5, 2017

I really need to use this option in my code. Any idea when you will release this fix?

@jeddy3 jeddy3 merged commit ae02c5d into stylelint:master Sep 5, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 95.625%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Sep 5, 2017

Changelog:

  • Fixed: --ignore-pattern in CLI (#2851).

Any idea when you will release this fix?

I'll drop a patch release now.

@andreffvalente

This comment has been minimized.

andreffvalente commented Sep 5, 2017

Thank you @jeddy3!

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Sep 5, 2017

Released in 8.1.1.

@ntwb

This comment has been minimized.

Member

ntwb commented Sep 6, 2017

It would be great if lib/cli.js had some system tests, @satazor @andreffvalente would either of you be interested in adding some tests for the cli?

If so please check out #2142 😄

@satazor

This comment has been minimized.

Contributor

satazor commented Oct 13, 2017

Nobody ain't time for that. I'm joking obviously, but I'm currently overwhelmed by work and personal stuff which means that it would take some time for me to do them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment