New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negatives for ignore: ["inside-block"] in rule-empty-line-before #2894

Merged
merged 1 commit into from Sep 21, 2017

Conversation

4 participants
@gucong3000
Member

gucong3000 commented Sep 14, 2017

Which issue, if any, is this issue related to?

#2891

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@jeddy3

Fixture query.

@@ -5,6 +5,9 @@
h1 {

This comment has been minimized.

@jeddy3

jeddy3 Sep 14, 2017

Member

Would the following?

@media (min-width: 100px) {
  h1 {
    font-weight: normal;
  }
}

And no warnings be a more appropriate test for this change as your fixing false positives, right?

This comment has been minimized.

@gucong3000

gucong3000 Sep 15, 2017

Member

Would the following?

It has nothing to do with this.
The affected is that the <style> tag first-level child element is misjudged as nested.

And no warnings be a more appropriate test for this change as your fixing false positives, right?

It is not "false positives", It is "missed warnings"
(I don't know if my English is appropriate, title modified, please help correct English grammar)

This comment has been minimized.

@jeddy3

jeddy3 Sep 15, 2017

Member

The affected is that the <style> tag first-level child element is misjudged as nested.

Oooo, I see now. Sorry, I misunderstood.

It is not "false positives", It is "missed warnings"

I've just been using "false negatives" for those :)

@gucong3000 gucong3000 changed the title from Fix false positives for ignore: ["inside-block"] in rule-empty-line-before to Fix missed warnings for ignore: ["inside-block"] in rule-empty-line-before Sep 15, 2017

@jeddy3 jeddy3 changed the title from Fix missed warnings for ignore: ["inside-block"] in rule-empty-line-before to Fix false negatives for ignore: ["inside-block"] in rule-empty-line-before Sep 15, 2017

@jeddy3

jeddy3 approved these changes Sep 15, 2017

expect(ruleEmptyLineBeforeResult.warnings.length).toBe(0);
expect(ruleEmptyLineBeforeResult.errored).toBe(true);
expect(ruleEmptyLineBeforeResult.warnings.length).toBe(1);
expect(ruleEmptyLineBeforeResult.warnings[0].line).toBe(8);

This comment has been minimized.

@ntwb

ntwb Sep 20, 2017

Member

What are the 8 warnings added in this change?

This comment has been minimized.

@gucong3000

gucong3000 Sep 20, 2017

Member

Not 8 warnings, just 1. 8 is line number.

@jeddy3 jeddy3 merged commit ec0552e into master Sep 21, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0006%) to 95.627%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Sep 21, 2017

  • Fixed: rule-empty-line-before false positives for ignore: ["inside-block"] and CSS in HTML (#2894).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment