New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for shared-line comments in comment-empty-line-before #2986

Merged
merged 1 commit into from Oct 25, 2017

Conversation

3 participants
@hudochenkov
Member

hudochenkov commented Oct 24, 2017

Which issue, if any, is this issue related to?

#2980

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@jeddy3

jeddy3 approved these changes Oct 24, 2017

Nice!

@gucong3000

It looks great.

@jeddy3 jeddy3 changed the title from Use more correct comparison in isSharedLineComment to Fix false positives for shared-line comments in comment-empty-line-before Oct 25, 2017

@jeddy3 jeddy3 merged commit c8c5981 into master Oct 25, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.677%
Details

@jeddy3 jeddy3 deleted the issue-2980-fix-shared-line-comment branch Oct 25, 2017

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Oct 25, 2017

  • Fixed: comment-empty-line-before false positives for shared-line comments (#2986).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment