New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreValues: [] to value-no-vendor-prefix #3015

Merged
merged 5 commits into from Nov 12, 2017

Conversation

4 participants
@Bebersohl
Contributor

Bebersohl commented Nov 8, 2017

Which issue, if any, is this issue related to?

#3009

Is there anything in the PR that needs further explanation?

No, I don't think so.

Let me know what you think.

Given:
```js
["-webkit-", "-moz-"]

This comment has been minimized.

@sindresorhus

sindresorhus Nov 9, 2017

The intention of the option is to ignore properties, not vendor prefixes. So here the user might specify:

["grab", "max-content"]

To have -webkit-grab and -moz-max-content ignored from the rule.

@CAYdenberg

Can you add some tests that are expected to be rejected?

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 12, 2017

I believe using the optionsMatches util will allows regex (within strings) to be accepted as well, see:

@CAYdenberg CAYdenberg merged commit 6abc9ce into stylelint:master Nov 12, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 95.676%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment