New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore: ["first-nested"] to declaration-empty-line-before #3103

Merged
merged 3 commits into from Jan 5, 2018

Conversation

3 participants
@jeddy3
Member

jeddy3 commented Jan 4, 2018

Which issue, if any, is this issue related to?

Closes #3101

Is there anything in the PR that needs further explanation?

No, it's self-explanatory.

@ntwb

ntwb approved these changes Jan 5, 2018

LGTM

@ntwb

This comment has been minimized.

Member

ntwb commented Jan 5, 2018

One thought, is it worth adding a note in the readme for this and #3104 that these are to help facilitate the use of Prettier?

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Jan 5, 2018

One thought, is it worth adding a note in the readme for this and #3104 that these are to help facilitate the use of Prettier?

I don't think it's a good idea. There is no reason promote tools in rules description.

@hudochenkov

There should be an empty line before

```css
a {
bottom: 15px;
top: 5px;

This comment has been minimized.

@hudochenkov

hudochenkov Jan 5, 2018

Member

There should be an empty line before.

This comment has been minimized.

@jeddy3

jeddy3 Jan 5, 2018

Member

Whoops.

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jan 5, 2018

@hudochenkov Fixed

@jeddy3 jeddy3 merged commit b38a9fc into master Jan 5, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 95.661%
Details

@jeddy3 jeddy3 deleted the issue-3101 branch Jan 5, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jan 5, 2018

  • Added: ignore: ["first-nested"] to declaration-empty-line-before (#3103).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment