New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Open Collective postinstall message #3180

Merged
merged 1 commit into from Feb 20, 2018

Conversation

3 participants
@m-allanson
Member

m-allanson commented Feb 19, 2018

Which issue, if any, is this issue related to?

Comment at #2955 (comment)

Is there anything in the PR that needs further explanation?

This removes the stylelint / Open Collective banner that appears after installing stylelint.

As stylelint is designed to be installed alongside other tools, we should probably err on the side of subtlety. What do you think @stylelint/core? I'm ok with this being closed if folks think we should keep the banner.

@hudochenkov

I'm a bit sceptic about Open Collective towards stylelint. So I don't see usefulness of this banner.

@ntwb

This comment has been minimized.

Member

ntwb commented Feb 20, 2018

Agreed, it's one big ad, merging this PR as is to remove the Open Collective postinstall

I did explore an option of minimalising the post install, but I still didn't think it was ideal.

Let's keep what we have on the READMe.md as is and remove the postinstall for now, we can revisit again down the road if others believe we should have something post npm install


If:
"postinstall": "opencollective postinstall" from package.json#L127 is changed to:
"postinstall": "opencollective postinstall stylelint --plain"

And
"logo": "https://opencollective.com/opencollective/logo.txt" from package.json#L200 is removed the resultant postinstall is:

screen shot 2018-02-20 at 6 38 31 pm

@ntwb

ntwb approved these changes Feb 20, 2018

@ntwb ntwb merged commit 4d75991 into master Feb 20, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.523%
Details

@ntwb ntwb deleted the opencollective-postinstall branch Feb 20, 2018

@m-allanson m-allanson referenced this pull request Feb 20, 2018

Closed

`npm install` spam #3182

@ntwb

This comment has been minimized.

Member

ntwb commented Feb 21, 2018

FYI: I've got no idea why I never saw that huge logo, I can't even open link it refers to, Cloudflare throws an error for me /shrug https://opencollective.com/opencollective/logo.txt

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Feb 21, 2018

I didn't saw big logo as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment