New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for at-root in indentation #3225

Merged
merged 4 commits into from Mar 23, 2018

Conversation

4 participants
@AndyOGo
Contributor

AndyOGo commented Mar 18, 2018

Which issue, if any, is this issue related to?

fixes #3168

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@kristerkari

This comment has been minimized.

Contributor

kristerkari commented Mar 18, 2018

Looks good, but how about adding a test for reject too?

AndyOGo added some commits Mar 19, 2018

@AndyOGo

This comment has been minimized.

Contributor

AndyOGo commented Mar 19, 2018

@kristerkari Thanks for your quick feedback. I added the missing reject test for both @at-root and @nest.

Btw every time I try to commit, your setup git hook running prettier complains and aborts my commit. I have to force it by --no-verify. Prettier can't autofix either and I don't see what's wrong with the code 🤔

@jeddy3

jeddy3 approved these changes Mar 20, 2018

Thanks for adding the reject tests. LGTM

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Mar 20, 2018

Btw every time I try to commit, your setup git hook running prettier complains and aborts my commit.

That's odd. Hopefully, it's just a glitch that'll go away. At the moment the CI is green so there are no formatting revisions to make.

@jeddy3 jeddy3 changed the title from Feature/scss at root for indentation to Fix false positives for at-root in indentation Mar 20, 2018

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Mar 20, 2018

Btw every time I try to commit, your setup git hook running prettier complains and aborts my commit.

That's odd. Hopefully, it's just a glitch that'll go away. At the moment the CI is green so there are no formatting revisions to make.

@AndyOGo Sorry for inconvenience. It will be fixed by #3232.

@jeddy3 It wasn't caught by CI, because we don't run npm run prettier:check in CI :)

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Mar 20, 2018

@jeddy3 It wasn't caught by CI, because we don't run npm run prettier:check in CI :)

Oh wow. I just assumed we did as I have it set up that way for all my day-job projects. I guess we never got around to it. Let's remedy that in another PR.

@AndyOGo

This comment has been minimized.

Contributor

AndyOGo commented Mar 20, 2018

No problem, Good it turns out right :)
I really loved my dev experience 😃

@hudochenkov

Thank you!

@jeddy3 jeddy3 merged commit 3be193c into stylelint:master Mar 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 95.537%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Mar 23, 2018

  • Fixed: indentation false positives for at-root (#3225).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment