New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for non-CSS blocks in max-empty-lines #3229

Merged
merged 1 commit into from Mar 23, 2018

Conversation

3 participants
@gucong3000
Member

gucong3000 commented Mar 20, 2018

Which issue, if any, is this issue related to?

Closes #3221

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

@jeddy3

jeddy3 approved these changes Mar 20, 2018

If this move away from style-search helps stylelint's compatibility with frameworks like Vue, then this LGTM.

@stylelint/core It'd be great to get a second pair of eyes on this.

@jeddy3 jeddy3 changed the title from Fix errors reported from non-CSS blocks for `max-empty-lines` to Fix false positives for non-CSS blocks in max-empty-lines Mar 20, 2018

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Mar 20, 2018

Would you mind running npm run prettier:fix, please? Or rebase your branch on master as it contains a fix for Prettier #3232.

@gucong3000 gucong3000 force-pushed the html_max-empty-lines branch from adb00c1 to e0b5670 Mar 21, 2018

@gucong3000

This comment has been minimized.

Member

gucong3000 commented Mar 21, 2018

If this move away from style-search

Yes.

Would you mind running npm run prettier:fix, please?

Done.

styleSearch({ source: rootString, target: "\n" }, match => {
checkMatch(rootString, match.endIndex, root);
});
if (root.constructor.name === "Document") {

This comment has been minimized.

@hudochenkov

hudochenkov Mar 21, 2018

Member

It's not a part of PostCSS, isn't it? Could you add a comment to the code explaining this if condition and what it Document, please?

@gucong3000 gucong3000 force-pushed the html_max-empty-lines branch from e0b5670 to 6643aba Mar 22, 2018

@hudochenkov

Thank you!

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Mar 22, 2018

@gucong3000 little tip: don't rebase PR without much need, if other people made review and requested changes. Rebase makes impossible to see what changes were made since last review. And we have to review whole thing again. “Squash and merge” will make history clean anyway.

@gucong3000

This comment has been minimized.

Member

gucong3000 commented Mar 23, 2018

@hudochenkov Thank you for reminding me.

@jeddy3 jeddy3 merged commit 9cd6f64 into master Mar 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 95.527%
Details

@jeddy3 jeddy3 deleted the html_max-empty-lines branch Mar 23, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Mar 23, 2018

  • Fixed: max-empty-lines false positives for non-CSS blocks (#3229).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment