New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autofix writing to files that aren't changed #3241

Merged
merged 1 commit into from Mar 30, 2018

Conversation

3 participants
@gucong3000
Member

gucong3000 commented Mar 26, 2018

Which issue, if any, is this issue related to?

Closes #3003

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@gucong3000 gucong3000 changed the title from skip write file when no change to Fix autofix writing to files that aren't changed Mar 26, 2018

@jeddy3 jeddy3 referenced this pull request Mar 26, 2018

Closed

Release 9.2 #3236

6 of 6 tasks complete
@gucong3000

This comment has been minimized.

Member

gucong3000 commented Mar 26, 2018

After restart node v8 job. travis-ci run pass again.

@gucong3000 gucong3000 force-pushed the write_changed branch from 7b801d2 to 34e7212 Mar 28, 2018

@jeddy3

jeddy3 approved these changes Mar 28, 2018

LGTM. If possible, a second pair of eyes on this means we can sneak it into 9.2.

@ntwb

ntwb approved these changes Mar 29, 2018

👍

@jeddy3 jeddy3 merged commit 1814f4d into master Mar 30, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0005%) to 96.038%
Details

@jeddy3 jeddy3 deleted the write_changed branch Mar 30, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Mar 30, 2018

  • Fixed: autofix erroneously writing to unchanged files (#3241).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment