Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix require (and test) performance #3242
These changes take about a 3rd off the test run times on the CIs and on my local machine:
These changes also reduce the
I've done a fair amount of investigation in the past two days and I've narrowed down two other possible areas of improvements:
@stylelint/core Can anyone see any potential problems with the changes in this PR? If people have time, it'd be great to get this PR tested against your project code bases.
Awesome, thanks! I've merged that and rebased this PR. The change seems to have shaved off another third.
Travis Node 8 (with coverage): 204.411s -> 166.244s -> 77.806s
On my machine, tests (with cleaned Jest cache) are now down to 54s and require time is around 344ms (down from 900ms -> 600ms).
I'm removing the "WIP" from the title. I believe this PR is ready to review and test.
Minor suggestion for clearer code, this looks good just looking at the code at least