New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove files with syntax errors from cache #3258

Merged
merged 1 commit into from Apr 17, 2018

Conversation

4 participants
@otakustay
Contributor

otakustay commented Apr 9, 2018

Close #3254

I think we should remove files from cache on any types of error, not only CssSyntaxError, however I don't know how to create other types of error, so the test case only covers CssSyntaxError

@jeddy3 jeddy3 requested a review from CAYdenberg Apr 10, 2018

@CAYdenberg

This comment has been minimized.

Contributor

CAYdenberg commented Apr 11, 2018

The code LGTM and I'll approve: just clarify: what other types of errors would we be concerned with? If the file doesn't exist it won't be cached (you could write a test for this I suppose?) - if an error occurs in stylelint it's on our end and we should fix it. I'm sure I'm just not thinking of something ...

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Apr 16, 2018

The code LGTM and I'll approve just clarify: what other types of errors would we be concerned with?

Do we need this clarification to approve and merge, or can we just go ahead?

@CAYdenberg

This comment has been minimized.

Contributor

CAYdenberg commented Apr 17, 2018

That's fair enough - if we think of something we can just add it later.

@CAYdenberg CAYdenberg merged commit c88f339 into stylelint:master Apr 17, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 95.978%
Details
@CAYdenberg

This comment has been minimized.

Contributor

CAYdenberg commented Apr 17, 2018

@ntwb @jeddy3 Sorry guys I've been out of the loop. Are we still updating the CHANGELOG on each merge to master? It now says I can't commit directly. I apologize for the breach of protocol here. Just let me know what I should do.

@otakustay otakustay deleted the otakustay:issue-3254 branch Apr 17, 2018

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Apr 17, 2018

@CAYdenberg yes. Try to edit changelog via Github interface. This is how it's intended to be edited.

rexboy77 pushed a commit to rexboy77/stylelint that referenced this pull request Apr 18, 2018

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Apr 23, 2018

  • Fixed: cache option hiding CssSyntaxError outputs (#3258).

bors bot added a commit to mozilla/delivery-console that referenced this pull request May 16, 2018

Merge #161
161: Update dependency stylelint to v9.2.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [stylelint](https://github.com/stylelint/stylelint) from `v9.2.0` to `v9.2.1`



<details>
<summary>Release Notes</summary>

### [`v9.2.1`](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md#&#8203;921)
[Compare Source](stylelint/stylelint@9.2.0...0a7c7ed)
-   Fixed: `cache` option hiding CssSyntaxError outputs ([#&#8203;3258](`stylelint/stylelint#3258)).
-   Fixed: regression with processors (e.g. styled-components) ([#&#8203;3261](`stylelint/stylelint#3261)).
-   Fixed: `no-descending-specificity` false positives for Sass nested properties ([#&#8203;3283](`stylelint/stylelint#3283)).
-   Fixed: `selector-pseudo-class-no-unknown` false positives proprietary webkit pseudo classes when applied to a simple selector ([#&#8203;3271](`stylelint/stylelint#3271)).

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment