New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix level 5 media queries in media-feature-name-no-unknown #3397

Merged
merged 3 commits into from Jun 21, 2018

Conversation

4 participants
@pkuczynski
Contributor

pkuczynski commented Jun 14, 2018

Fixes #3396

@jeddy3

jeddy3 approved these changes Jun 14, 2018

LGTM.

For those interested, this is in the Media Queries Level 5 editor's draft.

@evilebottnawi

evilebottnawi requested changes Jun 15, 2018 edited

Can we add also inverted-colors, light-level and prefers-reduced-transparency?

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Jun 15, 2018

I added prefers-reduced-transparency, but note that it's only a Draft and no browser seems to support it yet, while prefers-reduced-motion is supported in Safari https://caniuse.com/#search=prefers-reduced-motion

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Jun 16, 2018

@pkuczynski we have a lot of draft stuff right now, it is allow to avoid problem in future and fix compatobility with postcss plugins which polyfills this properties

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Jun 18, 2018

Sure, no probs. inverted-colors and light-level added. This PR is now complete, right?

@jeddy3 jeddy3 changed the title from Add prefers-reduced-motion media feature to Fix level 5 media queries in media-feature-name-no-unknown Jun 18, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 18, 2018

Sure, no probs. inverted-colors and light-level added.

Thanks!

This PR is now complete, right?

LGTM

@jeddy3 jeddy3 merged commit d06298f into stylelint:master Jun 21, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 95.997%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Jun 21, 2018

  • Fixed: media-feature-name-no-unknown false positives for level 5 names (#3397).
@ntwb

This comment has been minimized.

Member

ntwb commented Jul 3, 2018

p.s. A bit late, but welcome to the @stylelint organisation @pkuczynski 🎉

@pkuczynski pkuczynski deleted the pkuczynski:prefers-reduced-motion branch Jul 3, 2018

@pkuczynski

This comment has been minimized.

Contributor

pkuczynski commented Jul 3, 2018

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment