New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to no-extra-semicolons #3574

Merged
merged 1 commit into from Aug 22, 2018

Conversation

3 participants
@ota-meshi
Member

ota-meshi commented Aug 19, 2018

Which issue, if any, is this issue related to?

closes #3572

Is there anything in the PR that needs further explanation?

ex.

code:

 ;
a {;}
a { color: red; };

fixed:

 
a {}
a { color: red; }
@@ -63,620 +64,779 @@ testRule(rule, {
reject: [
{
code: ";",
fixed: "",

This comment has been minimized.

@ntwb

ntwb Aug 19, 2018

Member

Shouldn't the tests in this config: [true], section still include a single semi-colon?

This comment has been minimized.

@ota-meshi

ota-meshi Aug 19, 2018

Member

Are you saying it is better not to delete single semicolons?
if so, I think that this should be deleted because it is an extra semicolon.

This comment has been minimized.

@jeddy3

jeddy3 Aug 21, 2018

Member

if so, I think that this should be deleted because it is an extra semicolon.

Agreed. I think this semicolon is redundant and should be removed when autofixed.

@ota-meshi ota-meshi assigned ota-meshi and unassigned ota-meshi Aug 19, 2018

@jeddy3

jeddy3 approved these changes Aug 21, 2018

LGTM, thanks!

@ntwb

ntwb approved these changes Aug 22, 2018

@ntwb ntwb merged commit 00e1e26 into master Aug 22, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 96.17%
Details

@ntwb ntwb deleted the add-autofix/no-extra-semicolons branch Aug 22, 2018

@ntwb

This comment has been minimized.

Member

ntwb commented Aug 22, 2018

Changelog in 0dce74b

  • Added: no-extra-semicolons autofix (#3574).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment