New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for functional psuedo-classes selector-max-specificity #3711

Merged
merged 4 commits into from Oct 22, 2018

Conversation

6 participants
@Bilie
Contributor

Bilie commented Oct 8, 2018

Closes #3681

@Bilie Bilie requested a review from jeddy3 Oct 8, 2018

@jeddy3

Looking good.

@Bilie Can you rebase off master, please? That should fix the failing test now that #3714 is in.

@jeddy3

jeddy3 approved these changes Oct 17, 2018

LGTM, thanks!

@jeddy3 jeddy3 changed the title from Fix false positives selector max specificity to Fix false positives selector-max-specificity Oct 17, 2018

@jeddy3 jeddy3 referenced this pull request Oct 17, 2018

Closed

Release 9.7.0 #3726

4 of 4 tasks complete
@ntwb

ntwb approved these changes Oct 21, 2018

Thanks 🙏

.replace(/:+/, "");
return (
parentNode.type === "pseudo" &&

This comment has been minimized.

@ybiquitous

ybiquitous Oct 22, 2018

Member

I think checking parentNode.type can be placed into if condition, but also current code is enough 👍

-if (parentNode && parentNode.value) {
+if (parentNode && parentNode.type === "pseudo" && parentNode.value) {

(This example can avoid creation of normalisedParentNode variable ☝️ )

@jeddy3 jeddy3 changed the title from Fix false positives selector-max-specificity to Fix false positives for functional psuedo-classes selector-max-specificity Oct 22, 2018

@jeddy3 jeddy3 merged commit 857d95f into stylelint:master Oct 22, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 96.386%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Oct 22, 2018

  • Fixed: selector-max-specificity false positives for functional psuedo-classes (#3711).
@alexander-schranz

This comment has been minimized.

alexander-schranz commented Oct 23, 2018

@Bilie awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment