Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to selector-max-empty-lines #3717

Merged

Conversation

5 participants
@Vizet
Copy link
Contributor

commented Oct 12, 2018

Which issue, if any, is this issue related to?

Closes #3611", added autofix to selector-max-empty-lines

Is there anything in the PR that needs further explanation?

After fix number empty lines in a row <= max

@vankop

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

Thanks for contribution!
@Vizet could you please add some tests with css comments? For instance,

.foo\r\n#this is comment\r\n{}
.foo\n#this is comment\n{}
.foo\n\n#this is comment\n\n#and this is comment too\n\n{}
@ntwb

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Some hints on how tests could be added to this PR can be taken from the value-list-max-empty-lines PR in #3814

@Vizet Vizet closed this Apr 10, 2019

@Vizet Vizet deleted the Vizet:selector-max-empty-lines__autofix branch Apr 10, 2019

@Vizet Vizet restored the Vizet:selector-max-empty-lines__autofix branch Apr 10, 2019

@Vizet Vizet reopened this Apr 12, 2019

@jeddy3

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

Just a lint error to fix please:

/home/travis/build/stylelint/stylelint/lib/rules/selector-max-empty-lines/index.js
71:13 error Expected blank line before this statement padding-line-between-statements

@jeddy3 jeddy3 removed the PR: needs tests label Apr 13, 2019

@Vizet Vizet force-pushed the Vizet:selector-max-empty-lines__autofix branch from 09d42e7 to 12493b1 Apr 13, 2019

@Vizet

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

Just a lint error to fix please:

/home/travis/build/stylelint/stylelint/lib/rules/selector-max-empty-lines/index.js
71:13 error Expected blank line before this statement padding-line-between-statements

Sorry, i had old version repository. I rebased on master

@jeddy3

jeddy3 approved these changes Apr 14, 2019

Copy link
Member

left a comment

Thanks, especially for updating those hundreds of tests!

LGTM.

@hudochenkov
Copy link
Member

left a comment

Thank you!

@hudochenkov hudochenkov merged commit 56f7234 into stylelint:master May 1, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 96.367%
Details
@hudochenkov

This comment has been minimized.

Copy link
Member

commented May 1, 2019

  • Added: selector-max-empty-lines autofix (#3717).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.