New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to media-feature-parentheses-space-inside #3720

Merged
merged 4 commits into from Oct 17, 2018

Conversation

3 participants
@yepninja
Member

yepninja commented Oct 15, 2018

@yepninja

This comment has been minimized.

Member

yepninja commented Oct 16, 2018

I had to fix snapshots. Now the order of the errors is more correct.

@jeddy3

@yepninja This is looking fab! Thanks a lot. It's great to see the value parser being put to use.

I've made one very minor request to do with the name of a variable, otherwise this LGTM.

@@ -31,50 +31,62 @@ const rule = function(expectation) {
// will be at atRule.raws.params.raw
const params = _.get(atRule, "raws.params.raw", atRule.params);
const indexBoost = atRuleParamIndex(atRule);
const errors = [];

This comment has been minimized.

@jeddy3

jeddy3 Oct 17, 2018

Member

Can we rename this to violations, please?

It's a convention we've adopted to:

  • help distinguish between things caught by the linter and actual errors, for example those thrown by the parsers.
  • act as an intermediary before those things are categorised into a particular severity e.g. "error" or "warning".

This comment has been minimized.

@yepninja

yepninja Oct 17, 2018

Member

Agreed. No problem at all.

This comment has been minimized.

@yepninja

@jeddy3 jeddy3 changed the title from Add autofix to rule `media-feature-parentheses-space-inside` to Add autofix to media-feature-parentheses-space-inside Oct 17, 2018

@vankop

@yepninja I have added small suggestion.

@vankop

vankop approved these changes Oct 17, 2018

@jeddy3

jeddy3 approved these changes Oct 17, 2018

@yepninja Thanks for making the change. LGTM.

@jeddy3 jeddy3 merged commit 0180dc5 into stylelint:master Oct 17, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.08%) to 96.296%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Oct 17, 2018

  • Added: media-feature-parentheses-space-inside autofix (#3720).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment