New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreFunctions: [] to unit-no-unkown #3736

Merged
merged 3 commits into from Nov 1, 2018

Conversation

3 participants
@Bilie
Contributor

Bilie commented Oct 21, 2018

Closes #3424

No, it's self explanatory.

@Bilie Bilie requested a review from jeddy3 Oct 21, 2018

@jeddy3

Thanks, looking good.

I've made a query about case sensitivity.

},
{
code:
"a { background-image: YOUR-image-set('/images/some-image-1x.jpg' 1x,'/images/some-image-2x.jpg' 2x,'/images/some-image-3x.jpg' 3x,); }"

This comment has been minimized.

@jeddy3

jeddy3 Oct 22, 2018

Member
Suggested change Beta
"a { background-image: YOUR-image-set('/images/some-image-1x.jpg' 1x,'/images/some-image-2x.jpg' 2x,'/images/some-image-3x.jpg' 3x,); }"
"a { background-image: YoUr-image-set('/images/some-image-1x.jpg' 1x,'/images/some-image-2x.jpg' 2x,'/images/some-image-3x.jpg' 3x,); }"
optionsMatches(
options,
"ignoreFunctions",
valueNode.value.toLowerCase()

This comment has been minimized.

@jeddy3

jeddy3 Oct 22, 2018

Member
Suggested change Beta
valueNode.value.toLowerCase()
valueNode.value

I don't think we want to lowercase this as it makes the case insensitivity flag (i) redundant.

```css
a {
background-image: YOUR-image-set(

This comment has been minimized.

@jeddy3

jeddy3 Oct 22, 2018

Member
Suggested change Beta
background-image: YOUR-image-set(
background-image: YoUr-image-set(

@jeddy3 jeddy3 changed the title from Add ignoreFunctions option to unit-no-unkown to Add ignoreFunctions: [] to unit-no-unkown Oct 22, 2018

@jeddy3

jeddy3 approved these changes Oct 27, 2018

@Bilie Thanks! LGTM.

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Oct 28, 2018

This is just waiting on a second review.

@hudochenkov

Good job!

@hudochenkov hudochenkov merged commit 97d351e into stylelint:master Nov 1, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.331%
Details
@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Nov 1, 2018

  • Added: ignoreFunctions:[] to unit-no-unkown (#3736).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment