New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreSelectors: [] to selector-no-vendor-prefix #3748

Merged
merged 7 commits into from Nov 27, 2018

Conversation

3 participants
@Bilie
Contributor

Bilie commented Oct 28, 2018

Closes #3197

No, it's self explanatory.

@Bilie Bilie requested a review from jeddy3 Oct 28, 2018

@jeddy3

@Bilie Thanks!

I've made a suggestion to use the optionsMatches util, which I think is better suited for these types of conditionals.

@@ -36,6 +49,14 @@ const rule = function(actual) {
parseSelector(selector, result, rule, selectorTree => {
selectorTree.walkPseudos(pseudoNode => {
if (isAutoprefixable.selector(pseudoNode.value)) {
if (

This comment has been minimized.

@jeddy3

jeddy3 Oct 29, 2018

Member

I believe optionsMatches will suffice here, like so.

@jeddy3

There's an odd appveyor test failing.

reject: [
{
code: "input:-ms-input-placeholder { color: pink; }",

This comment has been minimized.

@jeddy3

jeddy3 Oct 30, 2018

Member

I think this might need to a pseudo-element to appease appveyor: input::-ms-input-placeholder.

@jeddy3

jeddy3 approved these changes Nov 6, 2018

@Bilie Thanks for making the change. It looks like appveyor is happy now.

@jeddy3 jeddy3 referenced this pull request Nov 6, 2018

Closed

Release 9.8.0 #3779

4 of 4 tasks complete
@jeddy3

@Bilie My bad, I mistitled the original issue.

This option should be ignoreSelectors and not ignoreProperties. I've requested the changes as suggestions to make it easier for you.

Show resolved Hide resolved lib/rules/selector-no-vendor-prefix/README.md Outdated
Show resolved Hide resolved lib/rules/selector-no-vendor-prefix/__tests__/index.js Outdated
Show resolved Hide resolved lib/rules/selector-no-vendor-prefix/index.js Outdated
Show resolved Hide resolved lib/rules/selector-no-vendor-prefix/index.js Outdated

@jeddy3 jeddy3 changed the title from Add ignoreProperties: [] to selector-no-vendor-prefix to Add ignoreSelectors: [] to selector-no-vendor-prefix Nov 6, 2018

jeddy3 and others added some commits Nov 10, 2018

Replace ignoreProperties with ignoreSelectors
Co-Authored-By: Bilie <bilianavaleva@gmail.com>
Replace ignoreProperties with ignoreSelectors
Co-Authored-By: Bilie <bilianavaleva@gmail.com>
Replace ignoreProperties with ignoreSelectors
Co-Authored-By: Bilie <bilianavaleva@gmail.com>
Replace ignoreProperties with ignoreSelectors
Co-Authored-By: Bilie <bilianavaleva@gmail.com>
@jeddy3

jeddy3 approved these changes Nov 10, 2018

@Bilie Thanks for making the changes! LGTM.

@ntwb

ntwb approved these changes Nov 27, 2018

@ntwb ntwb merged commit ac09f8d into stylelint:master Nov 27, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.354%
Details
@ntwb

This comment has been minimized.

Member

ntwb commented Nov 27, 2018

Changelog 97a538f

Added: ignoreSelectors option to selector-no-vendor-prefix (#3748).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment