New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for Less variables and mixins in at-rule-* (#3749) #3759

Merged
merged 1 commit into from Oct 30, 2018

Conversation

5 participants
@glutentag
Contributor

glutentag commented Oct 30, 2018

Which issue, if any, is this issue related to?

Closes #3749

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@jeddy3

jeddy3 approved these changes Oct 30, 2018

@glutentag Thanks for your first PR. LGTM!

@@ -260,7 +260,7 @@ testRule(rule, {
},
{
code: "@import 'test'; @include mixin(1) { @content; };",
fixed: "@import 'test';\n\n @include mixin(1) {\n\n @content; };",

This comment has been minimized.

@jeddy3

jeddy3 Oct 30, 2018

Member

This changed is due to this bit in the isStandardSyntaxAtRule util. I'd consider the existing behaviour a bug and the changes in this PR fix it, even though it's unrelated to Less Syntax.

@jeddy3 jeddy3 merged commit 2d2ab16 into stylelint:master Oct 30, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 96.336%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Oct 30, 2018

  • Fixed: at-rule-* false positives for Less variables and mixins (#3759).
@XhmikosR

This comment has been minimized.

XhmikosR commented Oct 30, 2018

@jeddy3: will you cut a new patch release for this soon too?

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Oct 30, 2018

Yes, already on it #3763

@pvdlg

This comment has been minimized.

pvdlg commented Oct 30, 2018

It seems the same problem is still happening for the tule at-rule-semicolon-newline-after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment