New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for any `.sass` comments #3772

Merged
merged 3 commits into from Nov 6, 2018

Conversation

7 participants
@Grawl
Contributor

Grawl commented Nov 2, 2018

Which issue, if any, is this issue related to?

Fixes #3244

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 2, 2018

@Grawl Thanks.

@stylelint/core As this version is within our range but it fixes a reported bug, what is the procedure here? Do you merge this in and add a changelog entry related to the bug?

@evilebottnawi

This comment has been minimized.

Member

evilebottnawi commented Nov 2, 2018

@jeddy3 From the side stylelint it is fix the bug, like fixing any bugs, i think we need add this to CHANGELOG

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Nov 2, 2018

@jeddy3 because it within our range it doesn't guarantee, that this version will be installed for a user. In some circumstances 0.3.0—0.3.4 could be installed.

So yes, we need to bump version and updatee changelog to guarantee the fix.

@jeddy3 jeddy3 changed the title from update postcss-sass version to Fix error for SASS double slash comments in indentation Nov 2, 2018

@jeddy3

jeddy3 approved these changes Nov 2, 2018

@Grawl

This comment has been minimized.

Contributor

Grawl commented Nov 3, 2018

@Grawl Grawl changed the title from Fix error for SASS double slash comments in indentation to Fix error for any `.sass` comments Nov 3, 2018

@hudochenkov

This comment has been minimized.

Member

hudochenkov commented Nov 3, 2018

@Grawl no, it was internal discussion how are we going to tackle this. Please, revert the change to stylelint version, and changelog.

@Grawl

This comment has been minimized.

Contributor

Grawl commented Nov 3, 2018

sorry 👌

@ntwb

ntwb approved these changes Nov 5, 2018

@jeddy3 jeddy3 merged commit 2ba9900 into stylelint:master Nov 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.343%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 6, 2018

  • Fixed: error for single-line Sass comments (#3772).
@riophae

This comment has been minimized.

riophae commented Nov 14, 2018

With version 9.8.0, the issue still exists. I'm using LESS instead of SASS though.

image

src/style.less:

image

@ntwb

This comment has been minimized.

Member

ntwb commented Nov 14, 2018

@riophae Could you create a new issue for this please, it will be easier for us to track it form there 🙇‍♂️

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 14, 2018

@riophae The PR is specific to Sass syntax and not related to your issue.

I believe your docs.less violations are due to the regression outlined in #3754. That issue is labeled as "help wanted", so please consider helping out and contributing a fix.

Your style.less violation feels unrelated to that regression. As @ntwb suggests, please create a new issue for it (using the report a bug template) so that we can better help you.

@vladfaust

This comment has been minimized.

vladfaust commented Nov 27, 2018

Thank you for this PR, it bothered me so much! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment