New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positives for final newlines in max-empty-lines #3785

Merged
merged 2 commits into from Nov 9, 2018

Conversation

4 participants
@sswebcoder
Member

sswebcoder commented Nov 7, 2018

Fix for #3722

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 7, 2018

@sswebcoder Thank you for your PR!

The failing tests are due to #3779 (comment), which is currently blocking all PRs.

Feel free to help us patch the tests in that issue if you have time. It'll help us get your PR in.

@jeddy3 jeddy3 added the PR: blocked label Nov 7, 2018

@hudochenkov hudochenkov removed the PR: blocked label Nov 8, 2018

@jeddy3

jeddy3 approved these changes Nov 8, 2018

@hudochenkov Thanks for unblocking and running the tests again.

This PR LGTM.

@jeddy3 jeddy3 merged commit 66855d6 into stylelint:master Nov 9, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.348%
Details
@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 9, 2018

  • Fixed: max-empty-lines false positives for final newlines (#3785).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment