New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't parse ignored files #3801

Merged
merged 2 commits into from Nov 13, 2018

Conversation

3 participants
@ccqgithub
Contributor

ccqgithub commented Nov 10, 2018

… in these files.

Which issue, if any, is this issue related to?

A replacement for #3778.

now, below codes will throw a parse error even the .stylelintignore has pattern /**

const stylelint = require('stylelint');

stylelint.lint({
code: 'var a = {',
codeFilename: 'test.js',
}).then(data => console.log(data));

because lintsource throw parse error even the file is ignored.

this PR ignore files before lint, so avoid that errors.

Is there anything in the PR that needs further explanation?

e.g. "No, it's self explanatory."

season added some commits Nov 10, 2018

@CAYdenberg

This comment has been minimized.

Contributor

CAYdenberg commented Nov 11, 2018

This looks ... good. Don't know why we weren't already doing this 👍

@jeddy3

jeddy3 approved these changes Nov 12, 2018

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 12, 2018

@CAYdenberg Thanks for the review. I assume this is a patch and the following changelog entry will suffice?:

  • Fixed: ignored files are no longer parsed (#3801).

@jeddy3 jeddy3 changed the title from just to ignore the `ignored files` before lint, to avoid parse errors to Don't parse ignored files Nov 12, 2018

@CAYdenberg

This comment has been minimized.

Contributor

CAYdenberg commented Nov 12, 2018

@jeddy3 jeddy3 merged commit e8a91b9 into stylelint:master Nov 13, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.353%
Details
@ccqgithub

This comment has been minimized.

Contributor

ccqgithub commented Nov 27, 2018

@jeddy3 When can publish a version that include this? The issue throw errors when i use stylelint with vscode 😸

@jeddy3

This comment has been minimized.

Member

jeddy3 commented Nov 27, 2018

We can do a release today #3826.

@ccqgithub

This comment has been minimized.

Contributor

ccqgithub commented Nov 27, 2018

Oh, very thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment