Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disallowInList option to no-duplicate-selectors #3936

Merged
merged 5 commits into from Feb 19, 2019

Conversation

4 participants
@devsnice
Copy link
Contributor

commented Feb 4, 2019

Which issue, if any, is this issue related to?

Closes #3931

@devsnice

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

I don't understand why test in ignore.test.js was failed, maybe it's wired with some deps?

@hudochenkov

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

@devsnice this happens from time to time. We don't know what causes it. I've restarted the job.

@jeddy3
Copy link
Member

left a comment

@devsnice Thanks. It's looking good.

I've made two suggestions to the README.

Show resolved Hide resolved lib/rules/no-duplicate-selectors/README.md Outdated
Show resolved Hide resolved lib/rules/no-duplicate-selectors/README.md Outdated

@jeddy3 jeddy3 changed the title Issue 3931: add disallowInList option to no-duplicate-selectors rule Add disallowInList option to no-duplicate-selectors Feb 5, 2019

jeddy3 and others added some commits Feb 5, 2019

Update lib/rules/no-duplicate-selectors/README.md
Co-Authored-By: devsnice <devsnice@gmail.com>
Update lib/rules/no-duplicate-selectors/README.md
Co-Authored-By: devsnice <devsnice@gmail.com>
@devsnice

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

@devsnice Thanks. It's looking good.

I've made two suggestions to the README.

Thanks! Can you restart job?

@jeddy3

jeddy3 approved these changes Feb 6, 2019

Copy link
Member

left a comment

LGTM

@jeddy3 jeddy3 referenced this pull request Feb 18, 2019

Closed

Release 10.0.0 #3954

6 of 6 tasks complete

@jeddy3 jeddy3 merged commit 90cd748 into stylelint:master Feb 19, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 96.363%
Details
@jeddy3

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

Changelog:

  • Added: disallowInList to no-duplicate-selectors (#3936).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.