Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add at-rule-property-requirelist #3997

Merged
merged 1 commit into from Apr 3, 2019

Conversation

3 participants
@cahamilton
Copy link
Member

commented Mar 23, 2019

Which issue, if any, is this issue related to?

Resolves #3985. Adds new rule at-rule-property-requirelist.

Is there anything in the PR that needs further explanation?

Not specifically. Addresses request for new rule, with specs outlined in the discussion here: #3985 (comment). If theres any issues, just let me know!

@jeddy3

jeddy3 approved these changes Apr 2, 2019

Copy link
Member

left a comment

@cahamilton Thanks for this!

Sorry about the delay getting around to reviewing it... I was on holiday.

The PR looks good to me!

@jeddy3 jeddy3 changed the title Add rule: at-rule-property-requirelist Add at-rule-property-requirelist Apr 2, 2019

@jeddy3 jeddy3 referenced this pull request Apr 2, 2019

Closed

Release 10.0.0 #3954

6 of 6 tasks complete
@hudochenkov
Copy link
Member

left a comment

Looks very good!

@hudochenkov hudochenkov merged commit 6cef518 into master Apr 3, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0009%) to 96.363%
Details

@hudochenkov hudochenkov deleted the issue-3985 branch Apr 3, 2019

@hudochenkov

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

  • Added: at-rule-property-requirelist rule (#3997).
@cahamilton

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

@jeddy3 All good mate, hope you had a nice break

@hudochenkov @jeddy3 And thank you both for the review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.