Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore: ["comments"] to block-no-empty #4008

Merged
merged 1 commit into from Apr 7, 2019

Conversation

3 participants
@cahamilton
Copy link
Member

commented Apr 6, 2019

Which issue, if any, is this issue related to?

Closes #3925.

Adds secondary option of ignore: ["comments"] to rule block-no-empty

Is there anything in the PR that needs further explanation?

Not really. If there's any issues with it, let me know 馃憤

@jeddy3
Copy link
Member

left a comment

@cahamilton Thanks! Looking good.

I've just two minor doc requests.

Show resolved Hide resolved lib/rules/block-no-empty/README.md Outdated
Show resolved Hide resolved lib/rules/block-no-empty/README.md

@cahamilton cahamilton force-pushed the issue-3925 branch from f6d36fa to e094f4c Apr 7, 2019

@cahamilton

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2019

@jeddy3 Those doc changes have been made, let me know of any other changes 馃憤.

@jeddy3

jeddy3 approved these changes Apr 7, 2019

Copy link
Member

left a comment

Thanks for making the changes.

PR looks great to me!

@hudochenkov
Copy link
Member

left a comment

Good job!

@hudochenkov hudochenkov merged commit 2b73704 into master Apr 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 96.378%
Details

@hudochenkov hudochenkov deleted the issue-3925 branch Apr 7, 2019

@hudochenkov

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

  • Added: ignore: ["comments"] to block-no-empty (#4008).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.